Skip to content

fix(ast/estree): convert TSClassImplements::expression to MemberExpression in TS-ESTree AST#10607

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-24-fix_ast_estree_convert_tsclassimplements_expression_to_memberexpression_in_ts-estree_ast
Apr 24, 2025
Merged

fix(ast/estree): convert TSClassImplements::expression to MemberExpression in TS-ESTree AST#10607
graphite-app[bot] merged 1 commit intomainfrom
04-24-fix_ast_estree_convert_tsclassimplements_expression_to_memberexpression_in_ts-estree_ast

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 24, 2025

Part of #9705.

TS-ESLint parser represents X.Y in class C implements X.Y {} as a MemberExpression, whereas in our AST it's a TSQualifiedName. Convert to MemberExpression in TS-ESTree AST.

@github-actions github-actions bot added the A-ast Area - AST label Apr 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label Apr 24, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 24, 2025 19:21
@overlookmotel overlookmotel force-pushed the 04-24-fix_ast_estree_convert_tsclassimplements_expression_to_memberexpression_in_ts-estree_ast branch from 8617d3f to 415d3ad Compare April 24, 2025 19:23
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Instrumentation Performance Report

Merging #10607 will not alter performance

Comparing 04-24-fix_ast_estree_convert_tsclassimplements_expression_to_memberexpression_in_ts-estree_ast (24ab2f3) with main (0825834)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
Copy link
Member Author

overlookmotel commented Apr 24, 2025

Merge activity

…pression` in TS-ESTree AST (#10607)

Part of #9705.

TS-ESLint parser represents `X.Y` in `class C implements X.Y {}` as a `MemberExpression`, whereas in our AST it's a `TSQualifiedName`. Convert to `MemberExpression` in TS-ESTree AST.
@graphite-app graphite-app bot force-pushed the 04-24-fix_ast_estree_convert_tsclassimplements_expression_to_memberexpression_in_ts-estree_ast branch from 415d3ad to 24ab2f3 Compare April 24, 2025 19:31
@graphite-app graphite-app bot merged commit 24ab2f3 into main Apr 24, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-24-fix_ast_estree_convert_tsclassimplements_expression_to_memberexpression_in_ts-estree_ast branch April 24, 2025 19:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant