Skip to content

refactor(parser): remove return Result from read_regex#10598

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-24-refactor_parser_remove_return_result_from_read_regex_
Apr 27, 2025
Merged

refactor(parser): remove return Result from read_regex#10598
graphite-app[bot] merged 1 commit intomainfrom
04-24-refactor_parser_remove_return_result_from_read_regex_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 24, 2025

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 24, 2025
Copy link
Member Author

Boshen commented Apr 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 24, 2025

Merge activity

  • Apr 24, 11:44 AM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Apr 26, 10:49 PM EDT: Boshen added this pull request to the Graphite merge queue.
  • Apr 26, 11:03 PM EDT: Merged by the Graphite merge queue.

@Boshen Boshen force-pushed the 04-24-refactor_parser_remove_return_result_from_read_regex_ branch from 1650024 to 1a2db35 Compare April 27, 2025 02:42
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 27, 2025

CodSpeed Instrumentation Performance Report

Merging #10598 will not alter performance

Comparing 04-24-refactor_parser_remove_return_result_from_read_regex_ (76ea6a9) with main (bdcbeb4)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot force-pushed the 04-24-refactor_parser_remove_return_result_from_read_regex_ branch from 1a2db35 to 76ea6a9 Compare April 27, 2025 02:49
@graphite-app graphite-app bot merged commit 76ea6a9 into main Apr 27, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-24-refactor_parser_remove_return_result_from_read_regex_ branch April 27, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant