fix(oxc_minifier): should not unwrap referenceId in set_no_side_effects#10577
Closed
IWANABETHATGUY wants to merge 2 commits intomainfrom
Closed
fix(oxc_minifier): should not unwrap referenceId in set_no_side_effects#10577IWANABETHATGUY wants to merge 2 commits intomainfrom
set_no_side_effects#10577IWANABETHATGUY wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
IWANABETHATGUY
changed the title
IWANABETHATGUY
changed the title
set_no_side_effects
IWANABETHATGUY
changed the title
set_no_side_effectsset_no_side_effects
CodSpeed Instrumentation Performance ReportMerging #10577 will not alter performanceComparing Summary
|
IWANABETHATGUY
force-pushed
the
04-24-fix_should_not_unwrap_referenced_in_set_no_side_effects
branch
from
588b107 to
25ccd69
Compare
Contributor
Author
|
Before, the test would panic. |
IWANABETHATGUY
commented
Apr 24, 2025
Boshen
added a commit
that referenced
this pull request
Apr 29, 2025
closes #10577 fixes rolldown/rolldown#4261 DCE assumes semantic is correct, but semantic became sync after running the define global, causing the crash.
Boshen
deleted the
04-24-fix_should_not_unwrap_referenced_in_set_no_side_effects
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to rolldown/rolldown#4261