fix(ast/estree): fix TS-ESTree AST for TSModuleDeclaration#10574
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 23, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10574 will not alter performanceComparing Summary
|
Member
Author
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 23, 2025
Part of #9705. Our AST represents `module X.Y.Z {}` as 3 x nested `TSModuleDeclaration`s. TS-ESTree represents it as a single `TSModuleDeclaration`, with a nested tree of `TSQualifiedName`s as `id`. Additionally, TS-ESTree skips the `body` field if the module declaration has no body e.g. `module "foo";`. Align our TS-ESTree AST with these oddities.
graphite-app
bot
force-pushed
the
04-23-fix_ast_estree_fix_ts-estree_ast_for_tsmoduledeclaration_
branch
from
256c67e to
a2a32d7
Compare
overlookmotel
added a commit
that referenced
this pull request
Apr 23, 2025
Part of #9705. Our AST represents `module X.Y.Z {}` as 3 x nested `TSModuleDeclaration`s. TS-ESTree represents it as a single `TSModuleDeclaration`, with a nested tree of `TSQualifiedName`s as `id`. Additionally, TS-ESTree skips the `body` field if the module declaration has no body e.g. `module "foo";`. Align our TS-ESTree AST with these oddities.
overlookmotel
force-pushed
the
04-23-fix_ast_estree_fix_ts-estree_ast_for_tsmoduledeclaration_
branch
from
a2a32d7 to
587b555
Compare
Part of #9705. Our AST represents `module X.Y.Z {}` as 3 x nested `TSModuleDeclaration`s. TS-ESTree represents it as a single `TSModuleDeclaration`, with a nested tree of `TSQualifiedName`s as `id`. Additionally, TS-ESTree skips the `body` field if the module declaration has no body e.g. `module "foo";`. Align our TS-ESTree AST with these oddities.
graphite-app
bot
force-pushed
the
04-23-fix_ast_estree_fix_ts-estree_ast_for_tsmoduledeclaration_
branch
from
587b555 to
d1f5abb
Compare
graphite-app
bot
deleted the
04-23-fix_ast_estree_fix_ts-estree_ast_for_tsmoduledeclaration_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9705.
Our AST represents
module X.Y.Z {}as 3 x nestedTSModuleDeclarations. TS-ESTree represents it as a singleTSModuleDeclaration, with a nested tree ofTSQualifiedNames asid.Additionally, TS-ESTree skips the
bodyfield if the module declaration has no body e.g.module "foo";.Align our TS-ESTree AST with these oddities.