Skip to content

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 19, 2025

fixes #10503

using
foo = bar()

await using
foo = bar()

should be parsed as

using;
foo = bar()

await using;
foo = bar()

not

using foo = bar()

await using foo = bar()

Copy link
Member Author

Boshen commented Apr 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Apr 19, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 19, 2025

Merge activity

fixes #10503

```ts
using
foo = bar()

await using
foo = bar()
```

should be parsed as

```ts
using;
foo = bar()

await using;
foo = bar()
```

not

```ts
using foo = bar()

await using foo = bar()
```
@graphite-app graphite-app bot force-pushed the 04-19-fix_parser_fix_using_asi branch from 9290d76 to 7664bd0 Compare April 19, 2025 05:28
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 19, 2025

CodSpeed Instrumentation Performance Report

Merging #10504 will not alter performance

Comparing 04-19-fix_parser_fix_using_asi (7664bd0) with main (62178c2)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 7664bd0 into main Apr 19, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-19-fix_parser_fix_using_asi branch April 19, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(parser): using declaration asi

1 participant