refactor(ast/estree): move FunctionFormalParameters serializer to be with other serializers for FormalParameters
#10496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
Member
Author
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #10496 will not alter performanceComparing Summary
|
…e with other serializers for `FormalParameters` (#10496) Pure refactor. Revert a small change made in #10462. `FunctionFormalParameters` serializer acts on `Function`, which is not a TS type (even though the purpose of the custom serializer is to handle a TS-specific field). Keep this serializer with the rest of the serializers related to `FormalParameters`, rather than with the serializers which act on TS-only AST types.
graphite-app
bot
force-pushed
the
04-18-refactor_ast_estree_move_functionformalparameters_serializer_to_be_with_other_serializers_for_formalparameters_
branch
from
895647c to
cfdfa2e
Compare
graphite-app
bot
deleted the
04-18-refactor_ast_estree_move_functionformalparameters_serializer_to_be_with_other_serializers_for_formalparameters_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Revert a small change made in #10462.
FunctionFormalParametersserializer acts onFunction, which is not a TS type (even though the purpose of the custom serializer is to handle a TS-specific field). Keep this serializer with the rest of the serializers related toFormalParameters, rather than with the serializers which act on TS-only AST types.