refactor(ast)!: change TSInterfaceDeclaration::extends from Option<Vec> to Vec

[overlookmotel]

It wasn't possible for extends field to be Some containing an empty Vec because this is not legal code:

interface Foo extends {}

So use Vec for extends field, instead of Option<Vec>. This prevents creating an invalid AST, and simplifies code in various places.

[overlookmotel]

• refactor(ast)!: move type_parameters field to before extends in TSInterfaceDeclaration #10476
• refactor(ast)!: change TSInterfaceDeclaration::extends from Option<Vec> to Vec #10472 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10472 will not alter performance

_{Comparing 04-17-refactor_ast_change_tsinterfacedeclaration_extends_from_option_vec_to_vec_ (7212803) with main (fbf0ae2)}

Summary

✅ 36 untouched benchmarks

[overlookmotel]

The only remaining Option<Vec> in AST now is in ImportDeclaration's specifiers field:

oxc/crates/oxc_ast/src/ast/js.rs

Lines 2366 to 2380 in 1952e30

	pub struct ImportDeclaration<'a> {
	pub span: Span,
	/// `None` for `import 'foo'`, `Some([])` for `import {} from 'foo'`
	#[estree(via = ImportDeclarationSpecifiers)]
	pub specifiers: Option<Vec<'a, ImportDeclarationSpecifier<'a>>>,
	pub source: StringLiteral<'a>,
	#[estree(skip)]
	pub phase: Option<ImportPhase>,
	/// Some(vec![]) for empty assertion
	#[estree(rename = "attributes", via = ImportDeclarationWithClause)]
	pub with_clause: Option<Box<'a, WithClause<'a>>>,
	/// `import type { foo } from 'bar'`
	#[ts]
	pub import_kind: ImportOrExportKind,
	}

That one should stay as is, because None and Some([]) have different meanings.

[graphite-app]

Merge activity

• Apr 17, 10:23 PM EDT: Dunqing added this pull request to the Graphite merge queue.
• Apr 18, 2:25 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Test (ubuntu-latest)', 'Test (macos-latest)', 'Test wasm32-wasip1-threads', 'Clippy', 'Doc', 'Benchmark (lexer)', 'Miri', 'Benchmark (parser)', 'Benchmark (transformer)', 'Benchmark (isolated_declarations)', 'Benchmark (semantic)', 'Benchmark (minifier)', 'Benchmark (codegen)', 'Benchmark (formatter)').
• Apr 18, 5:33 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 18, 5:46 AM EDT: Merged by the Graphite merge queue.