fix(transformer/class-properties): private_field_count is incorrect when class only have accessor with private field

[Dunqing]

abstract class Foo {
  accessor prop: number = 1;
  static accessor prop2: number = 1;
  accessor #prop3: number = 1;
  accessor [prop4]: number = 1;
  private accessor prop5: number = 1;
  abstract accessor prop6: number;
}

This case only has a #prop3 private field with an accessor. Since we haven't supported transforming accessor yet, the class_details.is_transform_required is always false in this class, which caused the private_field_count to be incorrect. Moving the decremental part to the pop side so that we can make sure the private_props_prop can always be handled correctly.

[Dunqing]

• refactor(transformer/class-properties): debug assert private_field_count is 0 at end of transform #10457
• fix(transformer/class-properties): private_field_count is incorrect when class only have accessor with private field #10463 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10463 will not alter performance

_{Comparing 04-17-fix_transformer_class-properties_private_field_count_is_incorrect_when_class_only_have_accessor_with_private_field (45f8cc0) with main (b7e0536)}

Summary

✅ 36 untouched benchmarks

[overlookmotel]

Merge activity

• Apr 17, 6:14 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 17, 6:15 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Apr 17, 6:21 AM EDT: Merged by the Graphite merge queue.