fix(ast_visit): Utf8ToUtf16Converter process decorators before class#10449
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 17, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10449 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
04-16-fix_ast_visit_utf8toutf16converter_process_decorators_before_class
branch
from
3891368 to
1955293
Compare
Member
Merge activity
|
#10449) #10438 altered span of `Class` so it starts later in the case of `@dec export class C {}` and `@dec export default class {}`. Update `Utf8ToUtf16Converter` to handle this odd case, and visit decorators before the `export` keyword before processing the span start of `ExportNamedDeclaration` / `ExportDefaultDeclaration`, so that span offsets are still processed in ascending order.
graphite-app
bot
force-pushed
the
04-16-fix_ast_visit_utf8toutf16converter_process_decorators_before_class
branch
from
1955293 to
6d3734b
Compare
graphite-app
bot
deleted the
04-16-fix_ast_visit_utf8toutf16converter_process_decorators_before_class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10438 altered span of
Classso it starts later in the case of@dec export class C {}and@dec export default class {}.Update
Utf8ToUtf16Converterto handle this odd case, and visit decorators before theexportkeyword before processing the span start ofExportNamedDeclaration/ExportDefaultDeclaration, so that span offsets are still processed in ascending order.