Skip to content

fix(codegen): fix spaces before AssignmentTargetRest#10443

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-16-fix_codegen_fix_spaces_before_assignmenttargetrest_
Apr 17, 2025
Merged

fix(codegen): fix spaces before AssignmentTargetRest#10443
graphite-app[bot] merged 1 commit intomainfrom
04-16-fix_codegen_fix_spaces_before_assignmenttargetrest_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 16, 2025

Follow-on after #10431.

  • Don't print space before ...rest in [...rest] = arr;.
  • Do print space before ...rest in ({a, ...rest} = obj;.

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Apr 16, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review April 16, 2025 13:52
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 16, 2025

CodSpeed Instrumentation Performance Report

Merging #10443 will not alter performance

Comparing 04-16-fix_codegen_fix_spaces_before_assignmenttargetrest_ (82ba30b) with main (6d3734b)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 17, 2025
Copy link
Member

Boshen commented Apr 17, 2025

Merge activity

Follow-on after #10431.

* Don't print space before `...rest` in `[...rest] = arr;`.
* Do print space before `...rest` in `({a, ...rest} = obj;`.
@graphite-app graphite-app bot force-pushed the 04-16-fix_codegen_fix_spaces_before_assignmenttargetrest_ branch from 1b7002e to 82ba30b Compare April 17, 2025 01:31
@graphite-app graphite-app bot merged commit 82ba30b into main Apr 17, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-16-fix_codegen_fix_spaces_before_assignmenttargetrest_ branch April 17, 2025 01:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants