refactor(ast): ModuleDeclaration::with_clause return Option<&WithClause>#10441
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 16, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
Dunqing
approved these changes
Apr 16, 2025
CodSpeed Instrumentation Performance ReportMerging #10441 will not alter performanceComparing Summary
|
Member
Author
Merge activity
|
…lause>` (#10441) It's strange to return an `Option<&Box<WithClause>>` (`&Box` is a double-reference). Return `Option<&WithClause>` instead.
graphite-app
bot
force-pushed
the
04-16-refactor_ast_remove_arrayassignmenttarget_new_with_elements_and_objectassignmenttarget_new_with_properties_
branch
from
a0a23d6 to
09f4c30
Compare
graphite-app
bot
force-pushed
the
04-16-refactor_ast_moduledeclaration_with_clause_return_option_withclause_
branch
from
3ddddc8 to
192717c
Compare
Base automatically changed from
04-16-refactor_ast_remove_arrayassignmenttarget_new_with_elements_and_objectassignmenttarget_new_with_properties_
to
main
April 16, 2025 14:04
graphite-app
bot
deleted the
04-16-refactor_ast_moduledeclaration_with_clause_return_option_withclause_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's strange to return an
Option<&Box<WithClause>>(&Boxis a double-reference). ReturnOption<&WithClause>instead.