perf(parser): use ArenaVec to store decorators#10437
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 16, 2025
Merged
Conversation
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10437 will not alter performanceComparing Summary
|
Member
|
I may be able to move the decorators around ... but not today. |
Member
Merge activity
|
No performance changes show in the `CodeSpeed` because we don't have a benchmark that includes decorators. According to convention, we always store child/leaf ASTs used for building ASTs in an arena to avoid extra allocations. We have got many performances from this kind of change, so I think it is good!
graphite-app
bot
force-pushed
the
04-16-perf_parser_use_arenavec_to_store_decorators
branch
from
38847c0 to
93b8e86
Compare
graphite-app
bot
deleted the
04-16-perf_parser_use_arenavec_to_store_decorators
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No performance changes show in the
CodeSpeedbecause we don't have a benchmark that includes decorators. According to convention, we always store child/leaf ASTs used for building ASTs in an arena to avoid extra allocations. We have got many performances from this kind of change, so I think it is good!