Skip to content

perf(transformer): prevent calling splice or extend for empty Vec#10436

Closed
Dunqing wants to merge 1 commit into04-16-perf_transformer_minimize_statements_reduce_allocations_of_vecfrom
04-16-perf_transformer_prevent_calling_splice_or_extend_empty_vec
Closed

perf(transformer): prevent calling splice or extend for empty Vec#10436
Dunqing wants to merge 1 commit into04-16-perf_transformer_minimize_statements_reduce_allocations_of_vecfrom
04-16-perf_transformer_prevent_calling_splice_or_extend_empty_vec

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 16, 2025

No description provided.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 16, 2025
Copy link
Member Author

Dunqing commented Apr 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 16, 2025

CodSpeed Instrumentation Performance Report

Merging #10436 will not alter performance

Comparing 04-16-perf_transformer_prevent_calling_splice_or_extend_empty_vec (f8141df) with 04-16-perf_transformer_minimize_statements_reduce_allocations_of_vec (609c523)

Summary

✅ 36 untouched benchmarks

@Dunqing
Copy link
Member Author

Dunqing commented Apr 16, 2025

Oh, the performance hits rather than improves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant