Skip to content

perf(transformer/object_rest_spread): use ArenaVec to store values that will be used in constructing AST #10434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 16, 2025
Merged

perf(transformer/object_rest_spread): use ArenaVec to store values that will be used in constructing AST #10434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/oxc_transformer/src/es2018/object_rest_spread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ impl<'a, 'ctx> ObjectRestSpread<'a, 'ctx> {
}

let mut call_expr: Option<CallExpression<'a>> = None;
let mut props = vec![];
let mut props = ctx.ast.vec_with_capacity(obj_expr.properties.len());

for prop in obj_expr.properties.drain(..) {
if let ObjectPropertyKind::SpreadProperty(spread_prop) = prop {
Expand All @@ -509,12 +509,16 @@ impl<'a, 'ctx> ObjectRestSpread<'a, 'ctx> {

fn make_object_spread(
expr: &mut Option<CallExpression<'a>>,
props: &mut Vec<ObjectPropertyKind<'a>>,
props: &mut ArenaVec<'a, ObjectPropertyKind<'a>>,
transform_ctx: &'ctx TransformCtx<'a>,
ctx: &mut TraverseCtx<'a>,
) {
let had_props = !props.is_empty();
let obj = ctx.ast.expression_object(SPAN, ctx.ast.vec_from_iter(props.drain(..)));
let obj = ctx.ast.expression_object(
SPAN,
// Reserve maximize might be used space for new vec
mem::replace(props, ctx.ast.vec_with_capacity(props.capacity() - props.len())),
);
let arguments = if let Some(call_expr) = expr.take() {
let arg = Expression::CallExpression(ctx.ast.alloc(call_expr));
let arg = Argument::from(arg);
Expand Down
Loading