fix(parser): Report errors for duplicate extends/implements clauses(TS1172/1173/1175)#10420
Merged
fix(parser): Report errors for duplicate extends/implements clauses(TS1172/1173/1175)#10420
Conversation
…TS1172/TS1173/TS1175)
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Member
Author
|
Originally this PR is for #9705 , but related coverage test still fails. This is because TS-ESLint does not report an error for the case |
CodSpeed Instrumentation Performance ReportMerging #10420 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commented out lines are reported as errors by TS.
extendsimplementsimplements>extendsorderimplementsforinterfaceThe current OXC parser does not report any of these, this PR fixes them to report correctly.
First, I tried to raise this error in semantics checker, but it was impossible because parsed AST contains only single
superClassand singleimplements(comma separated).So I did it in parser.