Skip to content

perf(linter): replace phf_set with array in utils::express#10370

Closed
shulaoda wants to merge 0 commit intomainfrom
04-11-perf/replace-phf_set-with-array-in-utils-express
Closed

perf(linter): replace phf_set with array in utils::express#10370
shulaoda wants to merge 0 commit intomainfrom
04-11-perf/replace-phf_set-with-array-in-utils-express

Conversation

@shulaoda
Copy link
Contributor

Related to #10076

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 11, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10370 will improve performances by 3.72%

Comparing 04-11-perf/replace-phf_set-with-array-in-utils-express (8d0eb33) with main (3ed3669)

Summary

⚡ 1 improvements
✅ 35 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 8.1 ms 7.8 ms +3.72%

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
Copy link
Contributor

camc314 commented Apr 11, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 11, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
@graphite-app graphite-app bot closed this Apr 11, 2025
@graphite-app graphite-app bot force-pushed the 04-11-perf/replace-phf_set-with-array-in-utils-express branch from f30c7f8 to 8d0eb33 Compare April 11, 2025 14:54
@camc314
Copy link
Contributor

camc314 commented Apr 11, 2025

strange this is marked as closed, cause this did get merged

@shulaoda shulaoda deleted the 04-11-perf/replace-phf_set-with-array-in-utils-express branch April 11, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants