Skip to content

perf(linter): replace phf_set with array in utils::jest#10369

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-11-perf/replace-phf_set-with-array-in-utils-jest
Apr 11, 2025
Merged

perf(linter): replace phf_set with array in utils::jest#10369
graphite-app[bot] merged 1 commit intomainfrom
04-11-perf/replace-phf_set-with-array-in-utils-jest

Conversation

@shulaoda
Copy link
Contributor

Related to #10076

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 11, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10369 will degrade performances by 4.11%

Comparing 04-11-perf/replace-phf_set-with-array-in-utils-jest (fbd4f92) with main (8d0eb33)

Summary

❌ 1 regressions
✅ 35 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[react.development.js] 49.5 µs 51.7 µs -4.11%

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
Copy link
Contributor

camc314 commented Apr 11, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-11-perf/replace-phf_set-with-array-in-utils-jest branch from fc54a87 to fbd4f92 Compare April 11, 2025 14:55
@graphite-app graphite-app bot merged commit fbd4f92 into main Apr 11, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-11-perf/replace-phf_set-with-array-in-utils-jest branch April 11, 2025 14:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants