Skip to content

fix(transformer/decorator-metadata): serialize type reference nodes causing imports cannot be removed#10360

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-11-fix_transformer_decorator-metadata_serialize_type_reference_nodes_causing_imports_cannot_be_removed
Apr 16, 2025
Merged

fix(transformer/decorator-metadata): serialize type reference nodes causing imports cannot be removed#10360
graphite-app[bot] merged 1 commit intomainfrom
04-11-fix_transformer_decorator-metadata_serialize_type_reference_nodes_causing_imports_cannot_be_removed

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 11, 2025

close: #10348

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Apr 11, 2025
Copy link
Member Author

Dunqing commented Apr 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Instrumentation Performance Report

Merging #10360 will not alter performance

Comparing 04-11-fix_transformer_decorator-metadata_serialize_type_reference_nodes_causing_imports_cannot_be_removed (17d26d9) with main (f3ddefb)

Summary

✅ 36 untouched benchmarks

@Dunqing Dunqing force-pushed the 04-11-fix_transformer_decorator-metadata_serialize_type_reference_nodes_causing_imports_cannot_be_removed branch from 26b2341 to 577b5a1 Compare April 14, 2025 08:09
@Dunqing Dunqing marked this pull request as ready for review April 14, 2025 08:10
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 14, 2025 08:10
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I don't really understand this decorator metadata business, but I know you do Dunqing, and I don't see anything that sticks out as odd. So merge it!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
Copy link
Member

overlookmotel commented Apr 16, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-11-fix_transformer_decorator-metadata_serialize_type_reference_nodes_causing_imports_cannot_be_removed branch from 577b5a1 to 17d26d9 Compare April 16, 2025 20:10
@graphite-app graphite-app bot merged commit 17d26d9 into main Apr 16, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-11-fix_transformer_decorator-metadata_serialize_type_reference_nodes_causing_imports_cannot_be_removed branch April 16, 2025 20:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

type import is not removed

2 participants