Skip to content

fix(linter): fix false positives for no-control-regex#10345

Merged
Boshen merged 1 commit intomainfrom
04-09-fix_linter_fix_false_positives_for_no-control-regex_
Apr 10, 2025
Merged

fix(linter): fix false positives for no-control-regex#10345
Boshen merged 1 commit intomainfrom
04-09-fix_linter_fix_false_positives_for_no-control-regex_

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Apr 10, 2025

Addresses a TODO for no-control-regex now that we've fixed the spans for characters in the regular expression parser. This enables us to fix some false positives, because we can check if it was a \u or \x escape or not.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Apr 10, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Instrumentation Performance Report

Merging #10345 will degrade performances by 3.32%

Comparing 04-09-fix_linter_fix_false_positives_for_no-control-regex_ (9f60552) with main (426f8cb)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.82%
formatter[typescript.js] 7.2 ms 7.4 ms -3.32%

@camchenry camchenry force-pushed the 04-09-fix_linter_fix_false_positives_for_no-control-regex_ branch from 66c7bdf to 9f60552 Compare April 10, 2025 03:13
@camchenry camchenry marked this pull request as ready for review April 10, 2025 03:13
@Boshen Boshen merged commit 04e2fd4 into main Apr 10, 2025
29 checks passed
@Boshen Boshen deleted the 04-09-fix_linter_fix_false_positives_for_no-control-regex_ branch April 10, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: eslint(no-control-regex) warns \f as unexpected control character

2 participants