Skip to content

perf(linter): replace phf_set with array in react/exhaustive-deps #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 9, 2025
Merged

perf(linter): replace phf_set with array in react/exhaustive-deps #10337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions crates/oxc_linter/src/rules/react/exhaustive_deps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use std::hash::Hash;

use itertools::Itertools;
use phf::phf_set;
use rustc_hash::FxHashSet;

use oxc_ast::{
Expand Down Expand Up @@ -194,8 +193,7 @@ declare_oxc_lint!(
nursery
);

const HOOKS_USELESS_WITHOUT_DEPENDENCIES: phf::Set<&'static str> =
phf_set!("useCallback", "useMemo");
const HOOKS_USELESS_WITHOUT_DEPENDENCIES: [&str; 2] = ["useCallback", "useMemo"];

impl Rule for ExhaustiveDeps {
fn run<'a>(&self, node: &AstNode<'a>, ctx: &LintContext<'a>) {
Expand Down Expand Up @@ -227,7 +225,7 @@ impl Rule for ExhaustiveDeps {
let is_effect = hook_name.as_str().contains("Effect");

if dependencies_node.is_none() && !is_effect {
if HOOKS_USELESS_WITHOUT_DEPENDENCIES.contains(hook_name.as_str()) {
if HOOKS_USELESS_WITHOUT_DEPENDENCIES.contains(&hook_name.as_str()) {
ctx.diagnostic(dependency_array_required_diagnostic(
hook_name.as_str(),
call_expr.span(),
Expand Down
Loading