Skip to content

refactor(linter): remove duplicate ARIA property lists#10326

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-09-refactor_linter_remov_duplicate_aria_property_lists
Apr 9, 2025
Merged

refactor(linter): remove duplicate ARIA property lists#10326
graphite-app[bot] merged 1 commit intomainfrom
04-09-refactor_linter_remov_duplicate_aria_property_lists

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Apr 9, 2025

Removes some additional duplication of ARIA properties in other lint rules.

Copy link
Member Author

camchenry commented Apr 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 9, 2025
@camchenry camchenry force-pushed the 04-09-refactor_linter_add_ariaproperty_enum branch from dbe2f3e to cc3dc9e Compare April 9, 2025 04:40
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 9, 2025

CodSpeed Instrumentation Performance Report

Merging #10326 will degrade performances by 3.51%

Comparing 04-09-refactor_linter_remov_duplicate_aria_property_lists (9533d09) with main (67bd7aa)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.51%
formatter[typescript.js] 7.6 ms 7.2 ms +5.37%

@graphite-app graphite-app bot changed the base branch from 04-09-refactor_linter_add_ariaproperty_enum to graphite-base/10326 April 9, 2025 13:51
@camchenry camchenry force-pushed the 04-09-refactor_linter_remov_duplicate_aria_property_lists branch from 5df30c4 to 8706613 Compare April 9, 2025 14:06
@camchenry camchenry force-pushed the graphite-base/10326 branch from cc3dc9e to 67bd7aa Compare April 9, 2025 14:06
@camchenry camchenry changed the base branch from graphite-base/10326 to main April 9, 2025 14:06
@camchenry camchenry changed the title refactor(linter): remov duplicate ARIA property lists refactor(linter): remove duplicate ARIA property lists Apr 9, 2025
@camchenry camchenry marked this pull request as ready for review April 9, 2025 14:08
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Apr 9, 2025
Copy link
Member Author

camchenry commented Apr 9, 2025

Merge activity

Removes some additional duplication of ARIA properties in other lint rules.
@graphite-app graphite-app bot force-pushed the 04-09-refactor_linter_remov_duplicate_aria_property_lists branch from 8706613 to 9533d09 Compare April 9, 2025 14:14
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 9, 2025
@graphite-app graphite-app bot merged commit 9533d09 into main Apr 9, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 04-09-refactor_linter_remov_duplicate_aria_property_lists branch April 9, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant