Skip to content

refactor(linter): move diagnostic service to oxc_linter#10320

Closed
Sysix wants to merge 1 commit intomainfrom
04-08-refactor_linter_move_diagnostic_service_to_oxc_linter
Closed

refactor(linter): move diagnostic service to oxc_linter#10320
Sysix wants to merge 1 commit intomainfrom
04-08-refactor_linter_move_diagnostic_service_to_oxc_linter

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Apr 8, 2025

The Service is only currently used by oxlint. The goal is that the Runtime is not auto-fixing it and only sending the fixes.
The consumer should then decide what to do with the fixes. (fix in file system, report them, ...)

Copy link
Member Author

Sysix commented Apr 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Apr 8, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 8, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 8, 2025

CodSpeed Instrumentation Performance Report

Merging #10320 will degrade performances by 5.26%

Comparing 04-08-refactor_linter_move_diagnostic_service_to_oxc_linter (d95fea1) with main (e0b6c8c)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.71%
formatter[react.development.js] 43.7 µs 41.4 µs +5.42%
formatter[typescript.js] 7.2 ms 7.6 ms -5.26%

@Sysix Sysix force-pushed the 04-08-refactor_linter_move_diagnostic_service_to_oxc_linter branch from 3e43756 to f3fe069 Compare April 8, 2025 22:14
@Sysix Sysix force-pushed the 04-08-refactor_linter_move_diagnostic_service_to_oxc_linter branch from f3fe069 to d95fea1 Compare April 8, 2025 22:20
@Sysix Sysix closed this Apr 10, 2025
@Sysix Sysix deleted the 04-08-refactor_linter_move_diagnostic_service_to_oxc_linter branch May 9, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant