Skip to content

fix(minifier): panic when compressing a ? b() : b() #10311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Apr 8, 2025
Merged

fix(minifier): panic when compressing a ? b() : b() #10311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/oxc_minifier/src/peephole/minimize_conditional_expression.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,9 @@ impl<'a> PeepholeOptimizations {
if let (Expression::CallExpression(consequent), Expression::CallExpression(alternate)) =
(&mut expr.consequent, &mut expr.alternate)
{
if consequent.arguments.len() == alternate.arguments.len()
// `a ? b() : b()` is handled later
if !consequent.arguments.is_empty() &&
consequent.arguments.len() == alternate.arguments.len()
// we can improve compression by allowing side effects on one side if the other side is
// an identifier that is not modified after it is declared.
// but for now, we only perform compression if neither side has side effects.
Expand Down Expand Up @@ -652,6 +654,7 @@ mod test {
test("var a, b; a ? b(c, d) : b(e, d)", "var a, b; b(a ? c : e, d)");
test("var a, b; a ? b(...c) : b(...e)", "var a, b; b(...a ? c : e)");
test("var a, b; a ? b(c) : b(e)", "var a, b; b(a ? c : e)");
test("var a, b; a ? b() : b()", "var a, b; b()");
test("var a, b; a === 0 ? b(c) : b(e)", "var a, b; b(a === 0 ? c : e)");
test_same("var a; a === 0 ? b(c) : b(e)"); // accessing global `b` may assign a different value to `a`
test_same("var b; a === 0 ? b(c) : b(e)"); // accessing global `a` may assign a different value to `b`
Expand Down
Loading