Skip to content

feat(language_server): switch tower-lsp to tower-lsp-server#10298

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-07-feat_language_server_switch_tower-lsp_to_tower-lsp-server_
Apr 9, 2025
Merged

feat(language_server): switch tower-lsp to tower-lsp-server#10298
graphite-app[bot] merged 1 commit intomainfrom
04-07-feat_language_server_switch_tower-lsp_to_tower-lsp-server_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Apr 7, 2025

tower-lsp has been unmaintained for a longer time. tower-lsp-server is a community fork.

Haven't tested with vscode yet.

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-enhancement Category - New feature or request labels Apr 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10298 will degrade performances by 5.1%

Comparing 04-07-feat_language_server_switch_tower-lsp_to_tower-lsp-server_ (0370363) with main (2c66ac2)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.67%
formatter[typescript.js] 7.2 ms 7.6 ms -5.1%

@Sysix
Copy link
Member

Sysix commented Apr 9, 2025

Haven't tested with vscode yet.

Commands that shut down the server are failing now.
STRG + P and search for Oxc: Restart Oxc Server and Oxc: toggle enable

Anything else works 👍

grafik

2025-04-09 18:10:56.499 [info] [Trace - 6:10:56 PM] Sending request 'shutdown - (11)'.
2025-04-09 18:10:56.502 [info] 
thread 'main' panicked at crates/oxc_language_server/src/main.rs:503:43:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

grafik

@Sysix Sysix marked this pull request as ready for review April 9, 2025 16:57
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Apr 9, 2025
Copy link
Member

Sysix commented Apr 9, 2025

Merge activity

`tower-lsp` has been unmaintained for a longer time. `tower-lsp-server` is a community fork.

Haven't tested with vscode yet.
@graphite-app graphite-app bot force-pushed the 04-07-feat_language_server_switch_tower-lsp_to_tower-lsp-server_ branch from dc6bdcc to 0370363 Compare April 9, 2025 17:03
@graphite-app graphite-app bot merged commit 0370363 into main Apr 9, 2025
31 checks passed
@graphite-app graphite-app bot deleted the 04-07-feat_language_server_switch_tower-lsp_to_tower-lsp-server_ branch April 9, 2025 17:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 9, 2025
@Boshen Boshen mentioned this pull request Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants