Skip to content

fix(ast/estree): add TS fields to LabelIdentifier#10295

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-07-fix_ast_estree_add_ts_fields_to_labelidentifier_
Apr 7, 2025
Merged

fix(ast/estree): add TS fields to LabelIdentifier#10295
graphite-app[bot] merged 1 commit intomainfrom
04-07-fix_ast_estree_add_ts_fields_to_labelidentifier_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 7, 2025

Add missing fields to LabelIdentifier in TS AST. Part of #9705.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 7, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review April 7, 2025 14:28
@overlookmotel
Copy link
Member Author

Passes more TS-ESLint conformance tests, and doesn't break anything, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2025
Copy link
Member Author

overlookmotel commented Apr 7, 2025

Merge activity

  • Apr 7, 10:29 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 7, 10:31 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Apr 7, 10:32 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Apr 7, 10:44 AM EDT: Merged by the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10295 will degrade performances by 3.76%

Comparing 04-07-fix_ast_estree_add_ts_fields_to_labelidentifier_ (e42c040) with main (a26fd34)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.76%
formatter[typescript.js] 7.4 ms 7.2 ms +3.42%

Add missing fields to `LabelIdentifier` in TS AST. Part of #9705.
@graphite-app graphite-app bot force-pushed the 04-07-fix_ast_estree_add_ts_fields_to_labelidentifier_ branch from c742c4e to e42c040 Compare April 7, 2025 14:34
@graphite-app graphite-app bot merged commit e42c040 into main Apr 7, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-07-fix_ast_estree_add_ts_fields_to_labelidentifier_ branch April 7, 2025 14:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant