Skip to content

perf(linter): replace phf_set with array in eslint/valid-typeof#10293

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-07-perf/replace-phf_set-with-array-in-eslint/valid-typeof
Apr 7, 2025
Merged

perf(linter): replace phf_set with array in eslint/valid-typeof#10293
graphite-app[bot] merged 1 commit intomainfrom
04-07-perf/replace-phf_set-with-array-in-eslint/valid-typeof

Conversation

@shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Apr 7, 2025

Related to #10076

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Apr 7, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 7, 2025

CodSpeed Instrumentation Performance Report

Merging #10293 will degrade performances by 3.32%

Comparing 04-07-perf/replace-phf_set-with-array-in-eslint/valid-typeof (d9c4891) with main (e42c040)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.92%
formatter[typescript.js] 7.2 ms 7.4 ms -3.32%

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 7, 2025
Copy link
Member

Boshen commented Apr 7, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-07-perf/replace-phf_set-with-array-in-eslint/valid-typeof branch from 89eda2d to d9c4891 Compare April 7, 2025 15:18
@graphite-app graphite-app bot merged commit d9c4891 into main Apr 7, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 04-07-perf/replace-phf_set-with-array-in-eslint/valid-typeof branch April 7, 2025 15:21
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants