Skip to content

feat(transformer): enable using by default #10286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 7, 2025
Merged

feat(transformer): enable using by default #10286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_transformer/src/options/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl TransformOptions {
..JsxOptions::default()
},
env: EnvOptions::enable_all(/* include_unfinished_plugins */ false),
proposals: ProposalOptions::default(),
proposals: ProposalOptions { explicit_resource_management: true },
helper_loader: HelperLoaderOptions {
mode: HelperLoaderMode::Runtime,
..Default::default()
Expand Down
2 changes: 1 addition & 1 deletion napi/transform/src/transformer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ impl TryFrom<TransformOptions> for oxc::transformer::TransformOptions {
None => oxc::transformer::JsxOptions::enable(),
},
env,
proposals: ProposalOptions { explicit_resource_management: false },
proposals: ProposalOptions { explicit_resource_management: true },
helper_loader: options
.helpers
.map_or_else(HelperLoaderOptions::default, HelperLoaderOptions::from),
Expand Down
96 changes: 95 additions & 1 deletion tasks/coverage/snapshots/semantic_test262.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ commit: bc5c1417

semantic_test262 Summary:
AST Parsed : 44293/44293 (100.00%)
Positive Passed: 42483/44293 (95.91%)
Positive Passed: 42481/44293 (95.91%)
tasks/coverage/test262/test/annexB/language/function-code/if-decl-else-decl-a-func-block-scoping.js
semantic error: Symbol scope ID mismatch for "f":
after transform: SymbolId(3): ScopeId(4294967294)
Expand Down Expand Up @@ -8401,6 +8401,53 @@ semantic error: Scope flags mismatch:
after transform: ScopeId(4): ScopeFlags(Function)
rebuilt : ScopeId(2): ScopeFlags(Function | DirectEval)

tasks/coverage/test262/test/language/statements/await-using/throws-if-initializer-not-object.js
semantic error: Bindings mismatch:
after transform: ScopeId(2): ["_usingCtx", "x"]
rebuilt : ScopeId(2): ["_usingCtx"]
Bindings mismatch:
after transform: ScopeId(7): []
rebuilt : ScopeId(3): ["x"]
Bindings mismatch:
after transform: ScopeId(3): ["_usingCtx3", "x"]
rebuilt : ScopeId(7): ["_usingCtx3"]
Bindings mismatch:
after transform: ScopeId(11): []
rebuilt : ScopeId(8): ["x"]
Bindings mismatch:
after transform: ScopeId(4): ["_usingCtx4", "x"]
rebuilt : ScopeId(12): ["_usingCtx4"]
Bindings mismatch:
after transform: ScopeId(15): []
rebuilt : ScopeId(13): ["x"]
Bindings mismatch:
after transform: ScopeId(5): ["_usingCtx5", "x"]
rebuilt : ScopeId(17): ["_usingCtx5"]
Bindings mismatch:
after transform: ScopeId(19): []
rebuilt : ScopeId(18): ["x"]
Bindings mismatch:
after transform: ScopeId(6): ["_usingCtx6", "x"]
rebuilt : ScopeId(22): ["_usingCtx6"]
Bindings mismatch:
after transform: ScopeId(23): []
rebuilt : ScopeId(23): ["x"]
Symbol scope ID mismatch for "x":
after transform: SymbolId(0): ScopeId(2)
rebuilt : SymbolId(3): ScopeId(3)
Symbol scope ID mismatch for "x":
after transform: SymbolId(1): ScopeId(3)
rebuilt : SymbolId(6): ScopeId(8)
Symbol scope ID mismatch for "x":
after transform: SymbolId(2): ScopeId(4)
rebuilt : SymbolId(9): ScopeId(13)
Symbol scope ID mismatch for "x":
after transform: SymbolId(3): ScopeId(5)
rebuilt : SymbolId(12): ScopeId(18)
Symbol scope ID mismatch for "x":
after transform: SymbolId(5): ScopeId(6)
rebuilt : SymbolId(16): ScopeId(23)

tasks/coverage/test262/test/language/statements/class/cpn-class-decl-fields-computed-property-name-from-arrow-function-expression.js
semantic error: Scope children mismatch:
after transform: ScopeId(0): [ScopeId(1), ScopeId(4), ScopeId(5), ScopeId(6), ScopeId(7)]
Expand Down Expand Up @@ -15656,3 +15703,50 @@ Bindings mismatch:
after transform: ScopeId(2): []
rebuilt : ScopeId(2): ["a", "b", "rest"]

tasks/coverage/test262/test/language/statements/using/throws-if-initializer-not-object.js
semantic error: Bindings mismatch:
after transform: ScopeId(1): ["_usingCtx", "x"]
rebuilt : ScopeId(1): ["_usingCtx"]
Bindings mismatch:
after transform: ScopeId(6): []
rebuilt : ScopeId(2): ["x"]
Bindings mismatch:
after transform: ScopeId(2): ["_usingCtx3", "x"]
rebuilt : ScopeId(6): ["_usingCtx3"]
Bindings mismatch:
after transform: ScopeId(10): []
rebuilt : ScopeId(7): ["x"]
Bindings mismatch:
after transform: ScopeId(3): ["_usingCtx4", "x"]
rebuilt : ScopeId(11): ["_usingCtx4"]
Bindings mismatch:
after transform: ScopeId(14): []
rebuilt : ScopeId(12): ["x"]
Bindings mismatch:
after transform: ScopeId(4): ["_usingCtx5", "x"]
rebuilt : ScopeId(16): ["_usingCtx5"]
Bindings mismatch:
after transform: ScopeId(18): []
rebuilt : ScopeId(17): ["x"]
Bindings mismatch:
after transform: ScopeId(5): ["_usingCtx6", "x"]
rebuilt : ScopeId(21): ["_usingCtx6"]
Bindings mismatch:
after transform: ScopeId(22): []
rebuilt : ScopeId(22): ["x"]
Symbol scope ID mismatch for "x":
after transform: SymbolId(0): ScopeId(1)
rebuilt : SymbolId(2): ScopeId(2)
Symbol scope ID mismatch for "x":
after transform: SymbolId(1): ScopeId(2)
rebuilt : SymbolId(5): ScopeId(7)
Symbol scope ID mismatch for "x":
after transform: SymbolId(2): ScopeId(3)
rebuilt : SymbolId(8): ScopeId(12)
Symbol scope ID mismatch for "x":
after transform: SymbolId(3): ScopeId(4)
rebuilt : SymbolId(11): ScopeId(17)
Symbol scope ID mismatch for "x":
after transform: SymbolId(5): ScopeId(5)
rebuilt : SymbolId(15): ScopeId(22)

Loading
Loading