Skip to content

test(minifier): String::replace for objects with Symbol.replace#10260

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-05-test_minifier_string_replace_for_objects_with_symbol.replace_
Apr 6, 2025
Merged

test(minifier): String::replace for objects with Symbol.replace#10260
graphite-app[bot] merged 1 commit intomainfrom
04-05-test_minifier_string_replace_for_objects_with_symbol.replace_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 6, 2025

Just adding a test for an edge case.

@github-actions github-actions bot added the A-minifier Area - Minifier label Apr 6, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Apr 6, 2025
@sapphi-red sapphi-red marked this pull request as ready for review April 6, 2025 11:46
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 6, 2025

CodSpeed Instrumentation Performance Report

Merging #10260 will not alter performance

Comparing 04-05-test_minifier_string_replace_for_objects_with_symbol.replace_ (3a64819) with main (32ed9f4)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 6, 2025
Copy link
Member

Boshen commented Apr 6, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 04-05-test_minifier_string_replace_for_objects_with_symbol.replace_ branch from 8d053e2 to 3a64819 Compare April 6, 2025 14:33
@graphite-app graphite-app bot merged commit 3a64819 into main Apr 6, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-05-test_minifier_string_replace_for_objects_with_symbol.replace_ branch April 6, 2025 14:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants