Skip to content

perf(language_server): only restart internal linter once when multiple config changes detected #10256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 8, 2025
Merged

perf(language_server): only restart internal linter once when multiple config changes detected #10256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions crates/oxc_language_server/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,7 @@ impl LanguageServer for Backend {
self.init_nested_configs().await;
}

if changed_options.fix_kind() != changed_options.fix_kind() {
self.init_linter_config().await;
self.revalidate_open_files().await;
}

// revalidate the config and all open files
if changed_options.config_path != current_option.config_path {
info!("config path change detected {:?}", &changed_options.config_path);
if Self::needs_linter_restart(current_option, &changed_options) {
self.init_linter_config().await;
self.revalidate_open_files().await;
}
Expand Down Expand Up @@ -527,6 +520,12 @@ impl Backend {
.await;
}

fn needs_linter_restart(old_options: &Options, new_options: &Options) -> bool {
old_options.config_path != new_options.config_path
|| old_options.disable_nested_configs() != new_options.disable_nested_configs()
|| old_options.fix_kind() != new_options.fix_kind()
}

/// Searches inside root_uri recursively for the default oxlint config files
/// and insert them inside the nested configuration
async fn init_nested_configs(&self) {
Expand Down
Loading