Skip to content

refactor(traverse): remove repeated code#10245

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-04-refactor_traverse_remove_repeated_code
Apr 4, 2025
Merged

refactor(traverse): remove repeated code#10245
graphite-app[bot] merged 1 commit intomainfrom
04-04-refactor_traverse_remove_repeated_code

Conversation

@overlookmotel
Copy link
Member

No description provided.

@overlookmotel overlookmotel marked this pull request as ready for review April 4, 2025 20:19
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Apr 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel
Copy link
Member Author

Small refactor only, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
Copy link
Member Author

overlookmotel commented Apr 4, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #10245 will degrade performances by 3.24%

Comparing 04-04-refactor_traverse_remove_repeated_code (e53708e) with main (cc1267e)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.87%
formatter[typescript.js] 7.2 ms 7.4 ms -3.24%

@graphite-app graphite-app bot force-pushed the 04-04-refactor_traverse_remove_repeated_code branch from aa93f19 to e53708e Compare April 4, 2025 20:26
@graphite-app graphite-app bot merged commit e53708e into main Apr 4, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 04-04-refactor_traverse_remove_repeated_code branch April 4, 2025 20:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant