perf(codegen): optimize Codegen::print_list method

[Dunqing]

It looks like has fewer instructions than before. See https://godbolt.org/z/jE1o5rvGq

NOTE: This approach didn't bring notable performance improvement, so I don't have a strong opinion on which way.

[Dunqing]

• perf(codegen): optimize Codegen::print_list method #10242 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10242 will not alter performance

_{Comparing 04-05-perf_codegen_optimize_codegen_print_list_method (6c9b094) with main (d143e95)}

Summary

✅ 36 untouched benchmarks

[Boshen]

Look at the comment above this function, seems like it's better this time?

[Dunqing]

Look at the comment above this function, seems like it's better this time?

It seems better than the last optimization while maintaining readability.

[Dunqing]

It seems adding #[inline] has no impact on performance.

[Boshen]

Merge activity

• Apr 7, 3:35 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 7, 3:35 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 7, 3:43 AM EDT: Merged by the Graphite merge queue.

[overlookmotel]

Just to clarify, the purpose of this change is better readability? From the Godbolt link you gave, it looks like it makes no difference to assembly either way.

That's not criticism, I'm just interested.

[Dunqing]

Just to clarify, the purpose of this change is better readability? From the Godbolt link you gave, it looks like it makes no difference to assembly either way.

That's not criticism, I'm just interested.

Yes, the performance is unchanged. Boshen said that merging it because better readability.