Skip to content

fix(ast): fix Display impl for RegExpFlags#10235

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-04-fix_ast_fix_display_impl_for_regexpflags_
Apr 4, 2025
Merged

fix(ast): fix Display impl for RegExpFlags#10235
graphite-app[bot] merged 1 commit intomainfrom
04-04-fix_ast_fix_display_impl_for_regexpflags_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 4, 2025

I think this was incorrect before, because Formatter::write_str bypasses formatting options. str::fmt should be used instead.

Copy link
Member Author

overlookmotel commented Apr 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 4, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 4, 2025 14:57
@overlookmotel overlookmotel requested a review from Boshen April 4, 2025 15:00
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #10235 will create unknown performance changes

Comparing 04-04-fix_ast_fix_display_impl_for_regexpflags_ (08a0d5e) with main (5b4c2ae)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 43.6 µs N/A
🆕 formatter[typescript.js] N/A 7.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.3 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.9 ms N/A
🆕 mangler[react.development.js] N/A 293.8 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 166.3 ms N/A
🆕 minifier[react.development.js] N/A 1.9 ms N/A
🆕 minifier[typescript.js] N/A 293.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
Copy link
Member

Boshen commented Apr 4, 2025

Merge activity

I *think* this was incorrect before, because `Formatter::write_str` bypasses formatting options. `str::fmt` should be used instead.
@graphite-app graphite-app bot force-pushed the 04-04-perf_ast_remove_write_macro_where_unnecessary branch from 8c23206 to 5b4c2ae Compare April 4, 2025 15:45
@graphite-app graphite-app bot force-pushed the 04-04-fix_ast_fix_display_impl_for_regexpflags_ branch from 210a2bf to 08a0d5e Compare April 4, 2025 15:45
Base automatically changed from 04-04-perf_ast_remove_write_macro_where_unnecessary to main April 4, 2025 15:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
@graphite-app graphite-app bot merged commit 08a0d5e into main Apr 4, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 04-04-fix_ast_fix_display_impl_for_regexpflags_ branch April 4, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants