fix(various): unwrap Result of write! macro#10228
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 4, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10228 will degrade performances by 3.5%Comparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
#10196 replaced the anti-pattern of `str.push_str(&format!("..."));` with `let _ = write!(str, "...");`. However, this ignores the `Result` returned by `write!` macro. It's unspecified what happens when the `String` reaches capacity - it may return `Result::Err`, or may panic. Ensure we get a panic, rather than silently generating incorrect output by calling `unwrap()` on the `Result`. This problem could never arise in practice on 64-bit systems because max capacity of `String` is enormous, but it's not impossible on 32-bit systems (e.g. WASM).
graphite-app
bot
force-pushed
the
04-04-fix_various_unwrap_result_of_write_macro
branch
from
a0b64f3 to
d691701
Compare
graphite-app
bot
deleted the
04-04-fix_various_unwrap_result_of_write_macro
branch
This was referenced Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10196 replaced the anti-pattern of
str.push_str(&format!("..."));withlet _ = write!(str, "...");.However, this ignores the
Resultreturned bywrite!macro. It's unspecified what happens when theStringreaches capacity - it may returnResult::Err, or may panic. Ensure we get a panic, rather than silently generating incorrect output by callingunwrap()on theResult.This problem could never arise in practice on 64-bit systems because max capacity of
Stringis enormous, but it's not impossible on 32-bit systems (e.g. WASM).