Skip to content

refactor(ast_tools): use write_it! macro #10219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 4, 2025
Merged

refactor(ast_tools): use write_it! macro #10219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tasks/ast_tools/src/generators/typescript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//! Generator for TypeScript type definitions for all AST types.

use std::{borrow::Cow, fmt::Write};
use std::borrow::Cow;

use itertools::Itertools;

Expand Down Expand Up @@ -117,7 +117,7 @@ fn generate_ts_type_def_for_struct(

if should_add_type_field_to_struct(struct_def) {
let type_name = struct_def.estree.rename.as_deref().unwrap_or_else(|| struct_def.name());
let _ = write!(fields_str, "\n\ttype: '{type_name}';");
write_it!(fields_str, "\n\ttype: '{type_name}';");
}

if !struct_def.estree.no_type {
Expand Down Expand Up @@ -272,7 +272,7 @@ fn generate_ts_type_def_for_struct_field_impl<'s>(

let field_camel_name = get_struct_field_name(field);
let question_mark = if field.estree.is_ts { "?" } else { "" };
let _ = write!(fields_str, "\n\t{field_camel_name}{question_mark}: {field_type_name};");
write_it!(fields_str, "\n\t{field_camel_name}{question_mark}: {field_type_name};");
}

/// Generate Typescript type definition for an extra struct field
Expand All @@ -288,7 +288,7 @@ fn generate_ts_type_def_for_added_struct_field(
panic!("No `ts_type` provided for ESTree converter `{converter_name}`");
};
let question_mark = if converter.estree.is_ts { "?" } else { "" };
let _ = write!(fields_str, "\n\t{field_name}{question_mark}: {ts_type};");
write_it!(fields_str, "\n\t{field_name}{question_mark}: {ts_type};");
}

/// Get the TS type definition for a converter.
Expand Down
Loading