Skip to content

refactor(codegen): Do not print useless comma for TSEnumMember#10213

Merged
Boshen merged 1 commit intomainfrom
refactor-codegen-tsenummember
Apr 4, 2025
Merged

refactor(codegen): Do not print useless comma for TSEnumMember#10213
Boshen merged 1 commit intomainfrom
refactor-codegen-tsenummember

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Apr 4, 2025

Current output:

enum X {A,B,}
//         ^

With this PR:

enum X {A,B}

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 4, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 4, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #10213 will degrade performances by 3.32%

Comparing refactor-codegen-tsenummember (4b7060f) with main (778b044)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.88%
formatter[typescript.js] 7.2 ms 7.4 ms -3.32%

@leaysgur leaysgur force-pushed the refactor-codegen-tsenummember branch from 8ba10cf to e4e1631 Compare April 4, 2025 01:37
@leaysgur leaysgur force-pushed the refactor-codegen-tsenummember branch from e4e1631 to 4b7060f Compare April 4, 2025 01:45
@leaysgur leaysgur requested a review from Dunqing as a code owner April 4, 2025 01:45
@github-actions github-actions bot added the A-isolated-declarations Isolated Declarations label Apr 4, 2025
@Boshen Boshen merged commit ca8f174 into main Apr 4, 2025
28 checks passed
@Boshen Boshen deleted the refactor-codegen-tsenummember branch April 4, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants