Skip to content

feat(ast_tools): derive Hash for AstType#10212

Merged
overlookmotel merged 1 commit intooxc-project:mainfrom
lazytype:derive_hash_for_ast_type
Apr 4, 2025
Merged

feat(ast_tools): derive Hash for AstType#10212
overlookmotel merged 1 commit intooxc-project:mainfrom
lazytype:derive_hash_for_ast_type

Conversation

@lazytype
Copy link
Contributor

@lazytype lazytype commented Apr 3, 2025

No description provided.

@lazytype lazytype requested a review from overlookmotel as a code owner April 3, 2025 20:28
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Apr 3, 2025
@lazytype lazytype force-pushed the derive_hash_for_ast_type branch from 6c3b963 to 78e45d4 Compare April 3, 2025 20:52
@lazytype lazytype force-pushed the derive_hash_for_ast_type branch from 78e45d4 to 76c09bf Compare April 4, 2025 02:02
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Instrumentation Performance Report

Merging #10212 will degrade performances by 3.41%

Comparing lazytype:derive_hash_for_ast_type (76c09bf) with main (778b044)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.88%
formatter[typescript.js] 7.2 ms 7.4 ms -3.41%

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 4, 2025

Merge activity

  • Apr 4, 9:39 AM UTC: @lazytype we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 4, 2025
@overlookmotel overlookmotel merged commit 8bbaedc into oxc-project:main Apr 4, 2025
25 checks passed
@overlookmotel
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants