Skip to content

fix(ast/estree): Fix TSImportType#10200

Merged
overlookmotel merged 1 commit intooxc-project:mainfrom
therewillbecode:fix/ts-import-type
Apr 3, 2025
Merged

fix(ast/estree): Fix TSImportType#10200
overlookmotel merged 1 commit intooxc-project:mainfrom
therewillbecode:fix/ts-import-type

Conversation

@therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Apr 3, 2025

Skips the isTypeOf field for the Estree serialiser on the TSImportType node.

Part of our broader work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 3, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 3, 2025

CodSpeed Instrumentation Performance Report

Merging #10200 will degrade performances by 4.65%

Comparing therewillbecode:fix/ts-import-type (644f6c6) with main (9ffb613)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 33 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.6 ms 7.9 ms -3.58%
formatter[react.development.js] 41.4 µs 43.4 µs -4.65%
formatter[typescript.js] 7.6 ms 7.2 ms +5.56%

@overlookmotel overlookmotel merged commit 06fc07c into oxc-project:main Apr 3, 2025
26 checks passed
@therewillbecode therewillbecode deleted the fix/ts-import-type branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants