Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/oxc_minifier/src/peephole/fold_constants.rs
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ impl<'a> PeepholeOptimizations {
None
};
left_last_quasi.value.cooked = new_cooked;
if right.quasis.len() > 0 {
if !right.quasis.is_empty() {
left_last_quasi.tail = false;
}
left.quasis.extend(right.quasis.drain(1..)); // first quasi is already handled
Expand Down
12 changes: 6 additions & 6 deletions crates/oxc_minifier/src/peephole/remove_unused_expression.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ impl<'a> PeepholeOptimizations {
let Expression::ArrayExpression(array_expr) = e else {
return false;
};
if array_expr.elements.len() == 0 {
if array_expr.elements.is_empty() {
return true;
}

Expand All @@ -211,7 +211,7 @@ impl<'a> PeepholeOptimizations {
state.changed = true;
}

if array_expr.elements.len() == 0 {
if array_expr.elements.is_empty() {
return true;
}

Expand Down Expand Up @@ -332,7 +332,7 @@ impl<'a> PeepholeOptimizations {
if e.to_primitive(&ctx).is_symbol() != Some(false) {
pending_to_string_required_exprs.push(e);
} else if !self.remove_unused_expression(&mut e, state, ctx) {
if pending_to_string_required_exprs.len() > 0 {
if !pending_to_string_required_exprs.is_empty() {
// flush pending to string required expressions
let expressions =
ctx.ast.vec_from_iter(pending_to_string_required_exprs.drain(..));
Expand Down Expand Up @@ -360,7 +360,7 @@ impl<'a> PeepholeOptimizations {
}
}

if pending_to_string_required_exprs.len() > 0 {
if !pending_to_string_required_exprs.is_empty() {
let expressions = ctx.ast.vec_from_iter(pending_to_string_required_exprs.drain(..));
let mut quasis = ctx.ast.vec_from_iter(
iter::repeat_with(|| {
Expand Down Expand Up @@ -419,7 +419,7 @@ impl<'a> PeepholeOptimizations {
pending_spread_elements.push(prop);
}
ObjectPropertyKind::ObjectProperty(prop) => {
if pending_spread_elements.len() > 0 {
if !pending_spread_elements.is_empty() {
// flush pending spread elements
transformed_elements.push(ctx.ast.expression_object(
prop.span(),
Expand Down Expand Up @@ -449,7 +449,7 @@ impl<'a> PeepholeOptimizations {
}
}

if pending_spread_elements.len() > 0 {
if !pending_spread_elements.is_empty() {
transformed_elements.push(ctx.ast.expression_object(
object_expr.span,
pending_spread_elements,
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_minifier/src/peephole/replace_known_methods.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ impl<'a> PeepholeOptimizations {
object: &Expression<'a>,
ctx: Ctx<'a, '_>,
) -> Option<Expression<'a>> {
if args.len() >= 1 {
if !args.is_empty() {
return None;
}
let Expression::StringLiteral(s) = object else { return None };
Expand Down
Loading