fix(minifier): non-constant argument passed to String::substring

[sapphi-red]

fixes. rolldown/rolldown#4009

[sapphi-red]

• feat(minifier): support advanced String::indexOf evaluation #10186
• fix(minifier): keep side effect in String::replace argument #10185
• fix(minifier): non-constant argument passed to String::substring #10184 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10184 will create unknown performance changes

_{Comparing 04-02-fix_minifier_non-constant_argument_passed_to_string_substring_ (bac8ca0) with main (b5f8e38)}

Summary

🆕 36 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	22.5 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	65.5 ms	N/A
🆕	formatter[antd.js]	N/A	7.6 ms	N/A
🆕	formatter[react.development.js]	N/A	43.8 µs	N/A
🆕	formatter[typescript.js]	N/A	7.4 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	58.3 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	21.5 µs	N/A
🆕	lexer[antd.js]	N/A	24.8 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.9 ms	N/A
🆕	lexer[checker.ts]	N/A	14.8 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.9 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3 s	N/A
🆕	mangler[antd.js]	N/A	16 ms	N/A
🆕	mangler[react.development.js]	N/A	293.9 µs	N/A
🆕	mangler[typescript.js]	N/A	39.6 ms	N/A
🆕	minifier[antd.js]	N/A	166.2 ms	N/A
🆕	minifier[react.development.js]	N/A	1.9 ms	N/A
🆕	minifier[typescript.js]	N/A	293.1 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[graphite-app]

Merge activity

• Apr 2, 9:00 AM EDT: Boshen added this pull request to the Graphite merge queue.
• Apr 2, 9:27 AM EDT: Merged by the Graphite merge queue.