Skip to content

refactor(parser): use AstBuilder::string_literal_with_lone_surrogates#10178

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-02-refactor_parser_use_astbuilder_string_literal_with_lone_surrogates_
Apr 2, 2025
Merged

refactor(parser): use AstBuilder::string_literal_with_lone_surrogates#10178
graphite-app[bot] merged 1 commit intomainfrom
04-02-refactor_parser_use_astbuilder_string_literal_with_lone_surrogates_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 2, 2025

Small refactor to parser. Use AstBuilder::string_literal_with_lone_surrogates method, rather than calling AstBuilder::string_literal and then setting lone_surrogates field afterwards.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 2, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 2, 2025 07:57
@overlookmotel
Copy link
Member Author

Tiny refactor, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
Copy link
Member Author

overlookmotel commented Apr 2, 2025

Merge activity

…s` (#10178)

Small refactor to parser. Use `AstBuilder::string_literal_with_lone_surrogates` method, rather than calling `AstBuilder::string_literal` and then setting `lone_surrogates` field afterwards.
@graphite-app graphite-app bot force-pushed the 04-02-refactor_parser_use_astbuilder_string_literal_with_lone_surrogates_ branch from eba2b62 to ec10d94 Compare April 2, 2025 08:07
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Instrumentation Performance Report

Merging #10178 will degrade performances by 3.13%

Comparing 04-02-refactor_parser_use_astbuilder_string_literal_with_lone_surrogates_ (ec10d94) with main (4d33af7)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 34 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
formatter[antd.js] 7.9 ms 7.6 ms +3.84%
formatter[typescript.js] 7.2 ms 7.4 ms -3.13%

@graphite-app graphite-app bot merged commit ec10d94 into main Apr 2, 2025
29 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
@graphite-app graphite-app bot deleted the 04-02-refactor_parser_use_astbuilder_string_literal_with_lone_surrogates_ branch April 2, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant