Skip to content

perf(transformer): do not update options from comments when only_remove_type_imports is enabled#10167

Merged
Boshen merged 1 commit intomainfrom
04-02-perf_transformer_do_not_update_options_from_comments_when_only_remove_type_imports_is_enabled
Apr 7, 2025
Merged

perf(transformer): do not update options from comments when only_remove_type_imports is enabled#10167
Boshen merged 1 commit intomainfrom
04-02-perf_transformer_do_not_update_options_from_comments_when_only_remove_type_imports_is_enabled

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 2, 2025

Because if only_remove_type_imports is enabled, no imports will be removed, so we don't care about TypeScript's jsx_pragma and jsx_pragma_frag options.

image

@Dunqing Dunqing requested a review from overlookmotel as a code owner April 2, 2025 02:31
@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Apr 2, 2025
Copy link
Member Author

Dunqing commented Apr 2, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Apr 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 2, 2025

CodSpeed Instrumentation Performance Report

Merging #10167 will create unknown performance changes

Comparing 04-02-perf_transformer_do_not_update_options_from_comments_when_only_remove_type_imports_is_enabled (3232470) with main (603abdc)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 7.9 ms N/A
🆕 formatter[react.development.js] N/A 43.5 µs N/A
🆕 formatter[typescript.js] N/A 7.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 15.8 ms N/A
🆕 mangler[react.development.js] N/A 293.9 µs N/A
🆕 mangler[typescript.js] N/A 39.4 ms N/A
🆕 minifier[antd.js] N/A 165.8 ms N/A
🆕 minifier[react.development.js] N/A 1.9 ms N/A
🆕 minifier[typescript.js] N/A 292.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tests.

@Dunqing Dunqing marked this pull request as draft April 2, 2025 03:06
@Dunqing Dunqing force-pushed the 04-02-perf_transformer_do_not_update_options_from_comments_when_only_remove_type_imports_is_enabled branch from d917173 to 76d5b54 Compare April 2, 2025 04:38
@Dunqing Dunqing marked this pull request as ready for review April 2, 2025 04:39
@Dunqing Dunqing requested a review from Boshen April 2, 2025 04:39
@Boshen Boshen force-pushed the 04-02-perf_transformer_do_not_update_options_from_comments_when_only_remove_type_imports_is_enabled branch from 76d5b54 to 3232470 Compare April 7, 2025 08:43
@Boshen Boshen merged commit f5b53d4 into main Apr 7, 2025
29 checks passed
@Boshen Boshen deleted the 04-02-perf_transformer_do_not_update_options_from_comments_when_only_remove_type_imports_is_enabled branch April 7, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants