Skip to content

feat(minifier): compress foo == true into foo == 1#10163

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-01-feat_minifier_compress_foo_true_into_foo_1_
Apr 2, 2025
Merged

feat(minifier): compress foo == true into foo == 1#10163
graphite-app[bot] merged 1 commit intomainfrom
04-01-feat_minifier_compress_foo_true_into_foo_1_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Apr 1, 2025

Compress foo == true into foo == 1.

This is safe because true and false are replaced with 1 and 0 first in IsLooselyEqual.
https://tc39.es/ecma262/multipage/abstract-operations.html#sec-islooselyequal:~:text=9.%20If,(y)).

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Apr 1, 2025
Copy link
Member Author

sapphi-red commented Apr 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review April 1, 2025 11:13
@sapphi-red sapphi-red marked this pull request as draft April 1, 2025 11:15
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Instrumentation Performance Report

Merging #10163 will not alter performance

Comparing 04-01-feat_minifier_compress_foo_true_into_foo_1_ (395b545) with main (3b72e5b)

Summary

✅ 36 untouched benchmarks

@sapphi-red sapphi-red force-pushed the 04-01-feat_minifier_compress_foo_true_into_foo_1_ branch from d64b22d to 0282325 Compare April 1, 2025 11:19
@sapphi-red sapphi-red marked this pull request as ready for review April 1, 2025 11:21
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
@sapphi-red sapphi-red force-pushed the 04-01-feat_minifier_compress_foo_true_into_foo_1_ branch from 0282325 to ecfb05d Compare April 2, 2025 03:14
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 2, 2025

Merge activity

Compress `foo == true` into `foo == 1`.

This is safe because `true` and `false` are replaced with `1` and `0` first in `IsLooselyEqual`.
https://tc39.es/ecma262/multipage/abstract-operations.html#sec-islooselyequal:~:text=9.%20If,(y)).
@graphite-app graphite-app bot force-pushed the 04-01-feat_minifier_compress_foo_true_into_foo_1_ branch from ecfb05d to 395b545 Compare April 2, 2025 03:24
@graphite-app graphite-app bot merged commit 395b545 into main Apr 2, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-01-feat_minifier_compress_foo_true_into_foo_1_ branch April 2, 2025 03:32
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant