Skip to content

fix(transformer/legacy-decorator): do not emit decorator metadata if the class is not decorated or it is typescript syntax#10154

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax
Apr 1, 2025
Merged

fix(transformer/legacy-decorator): do not emit decorator metadata if the class is not decorated or it is typescript syntax#10154
graphite-app[bot] merged 1 commit intomainfrom
04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Apr 1, 2025

Align with typescript

Copy link
Member Author

Dunqing commented Apr 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Instrumentation Performance Report

Merging #10154 will create unknown performance changes

Comparing 04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax (44efec7) with 04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively (e4029b8)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.7 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.6 ms N/A
🆕 formatter[antd.js] N/A 7.6 ms N/A
🆕 formatter[react.development.js] N/A 43.9 µs N/A
🆕 formatter[typescript.js] N/A 7.4 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.9 ms N/A
🆕 lexer[checker.ts] N/A 14.8 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294.7 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 165.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 291.6 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing force-pushed the 04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax branch from 2c587f7 to 92d2d89 Compare April 1, 2025 03:55
@Dunqing Dunqing force-pushed the 04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively branch from 5512f31 to 413b69d Compare April 1, 2025 03:55
@Dunqing Dunqing marked this pull request as ready for review April 1, 2025 05:22
@Dunqing Dunqing requested a review from overlookmotel as a code owner April 1, 2025 05:22
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 1, 2025

Merge activity

…the class is not decorated or it is typescript syntax (#10154)

Align with `typescript`
@graphite-app graphite-app bot force-pushed the 04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively branch from 413b69d to e4029b8 Compare April 1, 2025 05:32
@graphite-app graphite-app bot force-pushed the 04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax branch from 92d2d89 to 44efec7 Compare April 1, 2025 05:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 1, 2025
Base automatically changed from 04-01-refactor_transformer_legacy-decorator_split_the_transforming_decorated_class_into_two_parts_and_run_them_in_exit_class_and_exit_statement_respectively to main April 1, 2025 05:43
@graphite-app graphite-app bot merged commit 44efec7 into main Apr 1, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 04-01-fix_transformer_legacy-decorator_do_not_emit_decorator_metadata_if_the_class_isn_t_decorated_or_it_is_typescript_syntax branch April 1, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant