Skip to content

refactor(linter): gate rule docs behind feature#10027

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-25-refactor_linter_gate_rule_docs_behind_feature
Mar 25, 2025
Merged

refactor(linter): gate rule docs behind feature#10027
graphite-app[bot] merged 1 commit intomainfrom
03-25-refactor_linter_gate_rule_docs_behind_feature

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Mar 25, 2025

Adds a ruledocs feature for capturing the documentation text in lint rule macros. This is only enabled for the website task currently.

Locally, this removes ~429K bytes from the binary size when running cargo build --release -p oxlint

Screenshot 2025-03-25 at 12 18 23 AM

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Instrumentation Performance Report

Merging #10027 will not alter performance

Comparing 03-25-refactor_linter_gate_rule_docs_behind_feature (0f1e0e8) with main (2c53a72)

Summary

✅ 33 untouched benchmarks

@camchenry camchenry force-pushed the 03-25-refactor_linter_gate_rule_docs_behind_feature branch from a76ab8a to 592df77 Compare March 25, 2025 04:34
@camchenry camchenry marked this pull request as ready for review March 25, 2025 04:34
@camchenry camchenry requested a review from Boshen March 25, 2025 04:34
@Boshen
Copy link
Member

Boshen commented Mar 25, 2025

NICE!

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
Copy link
Member

Boshen commented Mar 25, 2025

Merge activity

  • Mar 25, 12:50 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 25, 12:51 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 25, 1:00 AM EDT: A user merged this pull request with the Graphite merge queue.

- related to #9998

Adds a `ruledocs` feature for capturing the documentation text in lint rule macros. This is only enabled for the website task currently.

Locally, this removes ~429K bytes from the binary size when running `cargo build --release -p oxlint`

<img width="247" alt="Screenshot 2025-03-25 at 12 18 23 AM" src="https://github.com/user-attachments/assets/52bbf254-eebf-45c5-8229-282fee921101" />
@graphite-app graphite-app bot force-pushed the 03-25-refactor_linter_gate_rule_docs_behind_feature branch from 592df77 to 0f1e0e8 Compare March 25, 2025 04:53
@graphite-app graphite-app bot merged commit 0f1e0e8 into main Mar 25, 2025
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 25, 2025
@graphite-app graphite-app bot deleted the 03-25-refactor_linter_gate_rule_docs_behind_feature branch March 25, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants