-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(linter) incorrect fixer in no_null
#5194
Comments
another one:
|
I don't have capacity for this, @camc314 can you handle it? |
Re-opening this because @Dunqing's PR only handled the first mentioned problem, not the second. |
I'll look at this - i think i will make the fixer a lot more concervative as to whether it fixes or doesn't. |
It's also resolved |
still broken 😞 const newDecorations = enabled ?
this._debugService.getModel().getBreakpoints().map(breakpoint => {
const parsed = CellUri.parse(breakpoint.uri);
if (!parsed || parsed.notebook.toString() !== this._notebookEditor.textModel!.uri.toString()) {
return null;
}
const options: INotebookCellDecorationOptions = {
overviewRuler: {
color: debugIconBreakpointForeground,
includeOutput: false,
modelRanges: [new Range(breakpoint.lineNumber, 0, breakpoint.lineNumber, 0)],
position: NotebookOverviewRulerLane.Left
}
};
return { handle: parsed.handle, options };
}).filter(x => !!x) as INotebookDeltaDecoration[]
: []; is being fixed to: const newDecorations = enabled ?
: []; |
@mysteryven do you want to fix this? |
I'm wondering if we should make this a suggestion 🤔 |
actually i'm not sure why our fixer works this way unicorn:
|
see https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/10518058484/job/29218160739?pr=25
is being fixed to
which is invalid TS
The text was updated successfully, but these errors were encountered: