Conversation
maxdeviant
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Pull Request Overview
Fixes oxc language server execution on Windows by using the .CMD wrapper script instead of the Unix shell script. The PR addresses the issue where the oxc language server fails to start on Windows due to the shell script shebang not being supported.
- Adds Windows platform detection to conditionally use
.CMDextension - Reorganizes imports and constants for better readability
- Updates fallback server path logic to handle Windows-specific executable format
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16
Not tested, but looks similar to oxc-project/oxc#12932.
The target file has a sh shebang, but can not work under windows.