chore: oxc.requireConfig search for .oxlintrc.jsonc too#110
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VS Code extension’s oxc.requireConfig gating to recognize .oxlintrc.jsonc in addition to .oxlintrc.json, aligning behavior and documentation with upstream oxc config discovery.
Changes:
- Extend config file globbing to include
.oxlintrc.jsoncfor startup gating and file watching. - Update user-facing descriptions/documentation to mention
.oxlintrc.json(c). - Tighten repo linting by enabling
typescript/no-floating-promisesinoxlint.config.json.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updates oxc.requireConfig setting description to mention .jsonc. |
| oxlint.config.json | Enables typescript/no-floating-promises for stricter promise handling. |
| client/tools/linter.ts | Adds .oxlintrc.jsonc to config detection glob and reuses it in several places. |
| README.md | Updates documentation text for oxc.requireConfig. |
Comments suppressed due to low confidence (1)
client/tools/linter.ts:44
- The comment above
allowedToStartServerstill says requireConfig checks for a.oxlintrc.jsonfile only, but the logic now also considers.oxlintrc.jsoncandoxlint.config.ts. Update the comment so it matches the current behavior.
const oxlintConfigDefaultFilePattern = `**/{.oxlintrc.json,.oxlintrc.jsonc,oxlint.config.ts}`;
export default class LinterTool implements ToolInterface {
// Global flag to check if the user allows us to start the server.
// When `oxc.requireConfig` is `true`, make sure one `.oxlintrc.json` file is present.
private allowedToStartServer: boolean = false;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
847984f to
729d30c
Compare
729d30c to
946c4ca
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
client/tools/linter.ts:44
- The comment above
allowedToStartServerstill says we only check for.oxlintrc.json, but the logic now also considers.oxlintrc.jsoncandoxlint.config.ts. Please update the comment so it matches the actual activation conditions (and stays correct if the pattern changes again).
// Global flag to check if the user allows us to start the server.
// When `oxc.requireConfig` is `true`, make sure one `.oxlintrc.json` file is present.
private allowedToStartServer: boolean = false;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sysix
commented
Mar 4, 2026
Signed-off-by: Alexander S. <sysix@sysix-coding.de>
Sysix
added a commit
that referenced
this pull request
Mar 4, 2026
commit ec126a8 Author: Alexander S. <sysix@sysix-coding.de> Date: Wed Mar 4 22:35:57 2026 +0100 chore: `oxc.requireConfig` search for `.oxlintrc.jsonc` too (#110) * chore: `oxc.requireConfig` search for `.oxlintrc.jsonc` too * Apply suggestion from @Sysix Signed-off-by: Alexander S. <sysix@sysix-coding.de> --------- Signed-off-by: Alexander S. <sysix@sysix-coding.de>
Sysix
added a commit
that referenced
this pull request
Mar 5, 2026
* chore: set `oxc.unusedDisableDirectives` default value to null * Squashed commit of the following: commit ec126a8 Author: Alexander S. <sysix@sysix-coding.de> Date: Wed Mar 4 22:35:57 2026 +0100 chore: `oxc.requireConfig` search for `.oxlintrc.jsonc` too (#110) * chore: `oxc.requireConfig` search for `.oxlintrc.jsonc` too * Apply suggestion from @Sysix Signed-off-by: Alexander S. <sysix@sysix-coding.de> --------- Signed-off-by: Alexander S. <sysix@sysix-coding.de> * update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upstream: oxc-project/oxc#19870