Skip to content

fix: only recreate the cache when yarn_pnp is toggled#943

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-24-fix_only_recreate_the_cache_when_yarn_pnp_is_toggled
Dec 24, 2025
Merged

fix: only recreate the cache when yarn_pnp is toggled#943
graphite-app[bot] merged 1 commit intomainfrom
12-24-fix_only_recreate_the_cache_when_yarn_pnp_is_toggled

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 24, 2025

fixes #930

Copy link
Member Author

Boshen commented Dec 24, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.36%. Comparing base (3a0575e) to head (60b627e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
- Coverage   94.45%   94.36%   -0.10%     
==========================================
  Files          17       17              
  Lines        3321     3321              
==========================================
- Hits         3137     3134       -3     
- Misses        184      187       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link

graphite-app bot commented Dec 24, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-24-fix_only_recreate_the_cache_when_yarn_pnp_is_toggled branch from fcc557e to 60b627e Compare December 24, 2025 15:02
@graphite-app graphite-app bot merged commit 60b627e into main Dec 24, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 12-24-fix_only_recreate_the_cache_when_yarn_pnp_is_toggled branch December 24, 2025 15:05
@Boshen Boshen mentioned this pull request Dec 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #943 will not alter performance

Comparing 12-24-fix_only_recreate_the_cache_when_yarn_pnp_is_toggled (60b627e) with main (3a0575e)1

Summary

✅ 12 untouched
⏩ 5 skipped2

Footnotes

  1. No successful run was found on main (60b627e) during the generation of this report, so 3a0575e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest version broke module type detection in my project

1 participant