Skip to content

fix: resolve absolute path to package with trailing slash#942

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-24-fix_resolve_absolute_path_to_package_with_trailing_slash
Dec 24, 2025
Merged

fix: resolve absolute path to package with trailing slash#942
graphite-app[bot] merged 1 commit intomainfrom
12-24-fix_resolve_absolute_path_to_package_with_trailing_slash

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 24, 2025

closes #938

Path::as_os_str is used in various places for faster compare,
the comparison fails when there is a trailing slash.

Copy link
Member Author

Boshen commented Dec 24, 2025


How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.45%. Comparing base (bed1c28) to head (3a0575e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #942   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files          17       17           
  Lines        3321     3321           
=======================================
  Hits         3137     3137           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graphite-app
Copy link

graphite-app bot commented Dec 24, 2025

Merge activity

closes #938

`Path::as_os_str` is used in various places for faster compare,
the comparison fails when there is a trailing slash.
@graphite-app graphite-app bot force-pushed the 12-24-fix_resolve_absolute_path_to_package_with_trailing_slash branch from 56b1950 to 3a0575e Compare December 24, 2025 12:50
@graphite-app graphite-app bot merged commit 3a0575e into main Dec 24, 2025
17 checks passed
@graphite-app graphite-app bot deleted the 12-24-fix_resolve_absolute_path_to_package_with_trailing_slash branch December 24, 2025 12:53
@Boshen Boshen mentioned this pull request Dec 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #942 will degrade performance by 3.15%

Comparing 12-24-fix_resolve_absolute_path_to_package_with_trailing_slash (3a0575e) with main (bed1c28)1

Summary

❌ 1 regression
✅ 11 untouched
⏩ 5 skipped2

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
resolver_memory[multi-thread] 475 µs 490.5 µs -3.15%

Footnotes

  1. No successful run was found on main (3a0575e) during the generation of this report, so bed1c28 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

This was referenced Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent resolution between /path/to/foo and /path/to/foo/

1 participant