Skip to content

Add additional Node builtins from v24.12.0#937

Closed
cap10morgan wants to merge 1 commit intooxc-project:mainfrom
HarperFast:update/node-builtins
Closed

Add additional Node builtins from v24.12.0#937
cap10morgan wants to merge 1 commit intooxc-project:mainfrom
HarperFast:update/node-builtins

Conversation

@cap10morgan
Copy link

I have locally implemented the import/no-unresolved rule, but found that it was failing with some common Node builtins because this list was out of date. So this is an update of it from Node v24.12.0 using the command in the comments.

Once this is merged, I'll put up a PR for the new rule over in the oxc repo.

I have implemented import/no-unresolved, but found that it was failing with some common Node builtins because this list was out of date. So this is an update of it from Node v24.12.0 using the command in the comments.
"wasi",
"worker_threads",
"zlib",
"node:sea",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 hmm these 4 complicates things, require('sea') is not available.

Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to modify the code for the four new additional node: only modules, leave this to me.

@Boshen Boshen self-assigned this Dec 24, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #937 will degrade performance by 4.25%

Comparing HarperFast:update/node-builtins (440e9db) with main (10833e2)

Summary

❌ 1 regression
✅ 11 untouched
⏩ 5 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
resolver_memory[multi-thread] 466.3 µs 487 µs -4.25%

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Boshen
Copy link
Member

Boshen commented Dec 24, 2025

Thank you for the PR. closed by #940

@Boshen Boshen closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants