Add additional Node builtins from v24.12.0#937
Closed
cap10morgan wants to merge 1 commit intooxc-project:mainfrom
Closed
Add additional Node builtins from v24.12.0#937cap10morgan wants to merge 1 commit intooxc-project:mainfrom
cap10morgan wants to merge 1 commit intooxc-project:mainfrom
Conversation
I have implemented import/no-unresolved, but found that it was failing with some common Node builtins because this list was out of date. So this is an update of it from Node v24.12.0 using the command in the comments.
Boshen
reviewed
Dec 24, 2025
| "wasi", | ||
| "worker_threads", | ||
| "zlib", | ||
| "node:sea", |
Member
There was a problem hiding this comment.
🤔 hmm these 4 complicates things, require('sea') is not available.
Boshen
reviewed
Dec 24, 2025
Member
Boshen
left a comment
There was a problem hiding this comment.
I need to modify the code for the four new additional node: only modules, leave this to me.
CodSpeed Performance ReportMerging #937 will degrade performance by 4.25%Comparing Summary
Benchmarks breakdown
Footnotes
|
Member
|
Thank you for the PR. closed by #940 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have locally implemented the
import/no-unresolvedrule, but found that it was failing with some common Node builtins because this list was out of date. So this is an update of it from Node v24.12.0 using the command in the comments.Once this is merged, I'll put up a PR for the new rule over in the
oxcrepo.